8198372: API to create a SelectableChannel to a FileDescriptor

[Brian Burkhalter]

On Jun 20, 2018, at 12:40 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:

> Actually I have one more comment.

Some more comments (which I initially had as comments on the CSR):

1: The phrasing "create a SelectableChannel TO a FileDescriptor" seems awkward. The verbiage in the java.nio.channels package description uses "from," e.g.,
"An appropriate channel can be constructed from an InputStream or an OutputStream, and conversely an InputStream or an OutputStream can be constructed from a channel."

2: There are two occurrences of {@link java.nio.channels.Selector Selectors} and one of {@code Selector}s. Should not the "s" be either in or out consistently?

3: In the API Note of implReleaseChannel it states "may be invoked while synchronized on the selector and its selected-key set." Should "may" instead be "should?”

4: For readWriteSelectableChannel might the phrasing
"read and write directly with the file descriptor"

be better as

"read from and write to the resource referenced by the file descriptor" ?


Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20180620/880106f7/attachment-0001.html>