RFR(JDK11/NIO) 8205058 throw CharacterCodingException --> Re: RFR (JDK11/NIO) 8201276: (fs) Add methods to Files for reading/writing a string from/to a file

[Joe Wang]

On 6/26/18, 11:57 AM, Alan Bateman wrote:
>
>
> On 26/06/2018 18:41, Joe Wang wrote:
>>
>> :
>>
>> Yes, combined with Sherman's suggestion eliminated the need for the 
>> new parameter. Here's the updated webrev:
>> http://cr.openjdk.java.net/~joehw/jdk11/8205058/webrev03/
> This looks good.
>
> Just a minor nit but newStringNoRepl and getBytesNoReply don't need to 
> check if the cause is null.

Removed the null check. The internal impl and test guarantees it's not 
null indeed:
http://cr.openjdk.java.net/~joehw/jdk11/8205058/webrev04/

Thanks,
Joe

>
> -Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20180626/bc8bf7a9/attachment.html>