RFR of JDK-8199215: Re-examine getFreePort method in test infrastructure library

Hamlin Li huaming.li at oracle.com
Thu Mar 15 08:43:10 UTC 2018



On 15/03/2018 3:40 PM, Alan Bateman wrote:
> On 15/03/2018 07:25, Hamlin Li wrote:
>> Would you please review the following patch?
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8199215
>>
>> webrev: http://cr.openjdk.java.net/~mli/8199215/webrev.00/
> Why are the following listed in the @build tags:
>
>   jdk.test.lib.Asserts
>   jdk.test.lib.JDKToolFinder
>   jdk.test.lib.JDKToolLauncher
>   jdk.test.lib.Platform
>   jdk.test.lib.process.*
>
> None of these are interesting to these tests. There was a lengthy 
> thread last year (I think started by JDK-8180805) where the issues of 
> implicit compilation were discussed. I thought that jtreg was changed 
> to compile test library classes in their own directory so that test 
> infrastructure classes that relied on implicit compilation could work 
> without the interim NoClassDefFoundError that we used to hit when 
> running tests concurrently and where tests didn't precisely list every 
> test library class.
Hi Alan,

Thank you for reviewing, I have updated the webrev in place.

Thank you
-Hamlin
>
> -Alan



More information about the nio-dev mailing list