8198753: (dc) DatagramChannel throws unspecified exceptions

[Brian Burkhalter]

On Mar 21, 2018, at 10:00 AM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:

> On Mar 21, 2018, at 9:50 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
>> On 20/03/2018 19:20, Brian Burkhalter wrote:
>>> 
>>> Test updates:
>>> 
>>> 1. ConnectedSend reverted aside from conversion to TestNG.
>>> 2. ConnectExceptions and SendExceptions added to cover the newly documented exceptions.
>>> 3. SendToUnresolved removed as this is now tested SendExceptions which also includes the @bug ID from SendToUnresolved.
>>> 
>>> http://cr.openjdk.java.net/~bpb/8198753/webrev.02/<http://cr.openjdk.java.net/%7Ebpb/8198753/webrev.02/>
>>> 
>> The tests looks okay although personally I would use @Test(expectedExceptions = ..) rather than expectThrows to avoid all the Runnables. A variant of what you have is for the run method to throw IOException to avoid the the try-catch in each test.
> 
> I can change it.

Updated tests to use expectedExceptions = ….

http://cr.openjdk.java.net/~bpb/8198753/webrev.03/

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20180321/27040b03/attachment.html>