8200256: java/nio/channels/AsynchronousChannelGroup/Basic.java fails intermittently

Chris Hegarty chris.hegarty at oracle.com
Tue Mar 27 16:30:37 UTC 2018


> On 27 Mar 2018, at 17:12, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
>> On 27/03/2018 08:18, Chris Hegarty wrote:
>> :
>> I think this looks fine ( at least that is what the code used to do before 8199791 ). The ( now safe ) racy interaction between wakeupCount and the use of a “single” byte, during shutdown, is a little subtle, maybe worth a comment for future maintainers.
>> 
> Thanks, I'll try to improve the comment before pushing this. I don't think this are has changed for several areas and it's not part if the current efforts to sort out the Selector issues.

Sorry, it’s not a comment on your changes, but on the existing code, that may have helped me when trying to review this, or avoided the regression altogether.

-Chris


More information about the nio-dev mailing list