8203765: java/nio/channels/Selector/SelectAndClose: add some prints and @intermittent tag
Alan Bateman
Alan.Bateman at oracle.com
Fri May 25 06:58:11 UTC 2018
On 24/05/2018 20:41, Brian Burkhalter wrote:
>
> On May 24, 2018, at 9:29 AM, Brian Burkhalter
> <brian.burkhalter at oracle.com <mailto:brian.burkhalter at oracle.com>> wrote:
>
>> On May 24, 2018, at 9:14 AM, Alan Bateman <Alan.Bateman at oracle.com
>> <mailto:Alan.Bateman at oracle.com>> wrote:
>>
>>> Waiting for the selectThread to terminate would at least allow you
>>> to capture the CloseSelectorException (assuming that is being thrown).
>>
>> I did not see a CSE mentioned in the issue description / comments
>> unless I missed something.
>
> Updated version: http://cr.openjdk.java.net/~bpb/8203765/webrev.01/
> <http://cr.openjdk.java.net/%7Ebpb/8203765/webrev.01/>
>
My preference would be to re-work the test so that main thread waits
until selectThread is in select. That eliminates the sleep(2000) and
avoids the potential ClosedSelectorException that happens when
closeThread closes the selector before selectThread blocks in select.
The changes you have are benign of course but think we should just fix
the test now rather than having to look at it again in 6 months when it
fails again.
-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20180525/724611c3/attachment-0001.html>
More information about the nio-dev
mailing list