8203765: java/nio/channels/Selector/SelectAndClose: add some prints and @intermittent tag
Brian Burkhalter
brian.burkhalter at oracle.com
Tue May 29 23:21:10 UTC 2018
On May 25, 2018, at 7:03 AM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> On May 24, 2018, at 11:58 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>
>> My preference would be to re-work the test so that main thread waits until selectThread is in select. That eliminates the sleep(2000) and avoids the potential ClosedSelectorException that happens when closeThread closes the selector before selectThread blocks in select. The changes you have are benign of course but think we should just fix the test now rather than having to look at it again in 6 months when it fails again.
>
> All right, I will take another look at it next week.
After studying your previous suggestion [1] in detail, I agree that it is better. I have implemented it in the updated patch [2] which has been run through build-and-test on Linux and Windows with 100 test repeats sans failure.
Thanks,
Brian
[1] http://mail.openjdk.java.net/pipermail/nio-dev/2018-May/005146.html
[2] http://cr.openjdk.java.net/~bpb/8203765/webrev.02/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20180529/75d03ccd/attachment.html>
More information about the nio-dev
mailing list