adding rsockets support into JDK

Alan Bateman Alan.Bateman at oracle.com
Sat Nov 17 09:17:43 UTC 2018


On 16/11/2018 17:28, Lu, Yingqi wrote:
>
> :
>
> I have updated the CSR https://bugs.openjdk.java.net/browse/JDK-8205186
>
> 1.I added the link to Javadoc files for jdk.net
>
> 2.I also zip the same rsocket_api folder and attached to the CSR
>
> 3.I updated the CSR content with finalized class names and function names
>
> Please review and let me know if everything looks OK.
>
>
The spec looks good. Just one minor comment - the final paragraph of the 
class description has a link to ExtendedSocketOptions which isn't 
interesting for RDMA sockets. One suggestion is drop the entire 
paragraph because the RDMA specific socket option don't any permission 
checks.

I added myself as Reviewer to the CSR and I see Chris has done this too 
So I think you should be able to finalize. It would be good if we could 
remove the specdiffs attachment that Brian has a few weeks ago as it's 
not in sync with the latest javadoc. I tried to remove it but I don't 
have access.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20181117/cff6c51d/attachment.html>


More information about the nio-dev mailing list