RFR: 8211842 IPv6_supported wrongly returns false when unix domain socket is bound to fd 0

Alan Bateman Alan.Bateman at oracle.com
Thu Nov 29 17:19:50 UTC 2018


On 28/11/2018 15:50, Michael McMahon wrote:
> Could I get the following fix reviewed please?
> The fix is pretty simple, but the test a bit more involved
> since the issue occurs when the JVM is launched in unusual circumstances
> where its stdin,out,err are connected to a UNIX domain socket.
> This occurs when java is launched by a node.js or Python script.
>
> http://cr.openjdk.java.net/~michaelm/8211842/webrev.1/
Definitely an unusual way to launch the VM. The update to net_util_md.c 
looks okay.

For the test then can UnixSocketFile be moved into its own source file 
to make it clearer? Also I think we should move the static fields and 
CHECK macro to the top of libInheritedChannel.c so that the JNI methods 
are all together.

-Alan




More information about the nio-dev mailing list