adding rsockets support into JDK
Brian Burkhalter
brian.burkhalter at oracle.com
Thu Oct 4 00:17:35 UTC 2018
Hi Lucy,
> On Oct 3, 2018, at 5:02 PM, Lu, Yingqi <yingqi.lu at intel.com> wrote:
>
> Thank you for all the help here!
>
> I also modified the CSR athttps://bugs.openjdk.java.net/browse/JDK-8205186 <https://bugs.openjdk.java.net/browse/JDK-8205186> by adding following lines to the end of it. I think we need to include all the API changes here?
Yes, all visible API changes need to be included.
>
> In addition, we will change the access modifier on the following methods:
>
> java.net.ServerSocket: ServerSocket(SocketImpl impl) from package private to protected
>
> java.net.SocketImpl: setSocket(Socket soc) and setServerSocket(ServerSocket soc) from package private to protected
On these latter two items, I recall that Alan had an objection:
"On the API changes then I see that two protected setXXXX methods have been added to SocketImpl. I think we should try to avoid that, even if it means using the shared secrets mechanism.” [1]
> Please review and let me know if there is anything missing.
Will do.
Thanks,
Brian
[1] http://mail.openjdk.java.net/pipermail/nio-dev/2018-August/005393.html
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20181003/39234966/attachment.html>
More information about the nio-dev
mailing list