adding rsockets support into JDK

[Brian Burkhalter]

Hi Lucy,

On Sep 23, 2018, at 8:07 PM, Lu, Yingqi <yingqi.lu at intel.com> wrote:

> Here is the version 10 of the patch http://cr.openjdk.java.net/~ylu/8195160.10.

To simplify the review I created a diff webrev versus version 9:

http://cr.openjdk.java.net/~bpb/8195160/webrev.10vs09/

> This patch includes all the changes Brian added based on version 09. In addition, I added following things:
>  
> 1.     Fixed JNI function names from various C files. This is due to the package name changing from rdma.ch to jdk.internal.net.rdma

Sorry I overlooked this.

In other C code I encountered an error while building:

openjdk/src/jdk.net/linux/native/libextnet/LinuxRdmaSocketDispatcherImpl.c:146:1: error: ‘handle’ defined but not used [-Werror=unused-function]
 handle(JNIEnv *env, jlong rv, char *msg)
 ^~~~~~

If the function is simply removed then it builds.

> 2.     Found a small issue with supportedOptions() from both java.net.Socket and java.net.ServerSocket. When a RDMA socket created after a regular TCP socket or verse visa, the private variable “options” can possibly return the wrong set of supported socket options. I create another variable named rdmaOptions and use that to track socket options for all the RDMA sockets.
> 3.     Removed some of the test cases from RDMA test set that are targeted only for old TCP socket issues. Currently, all the test cases passed on my CentOS 7 machine (with librdmacm and librdmacm-devel installed)
> 4.     Created one more test for non-Linux platform to test if UOE is thrown on RDMA sockets and channels.
> 5.     For test cases, I removed “include <rdma/rsocket.h>” from C file and –lrdmacm inside JTreg make file. Instead, I use dlopen and dlsym to load the library dynamically.

All tests pass in my local Linux build.

Aside from the dlopen/dlsym issue that you are working this is looking pretty good.

Thanks,

Brian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20180924/6041317d/attachment.html>