adding rsockets support into JDK

[Lu, Yingqi]

Hi Brian,

Please find version 12 of the patch available at http://cr.openjdk.java.net/~ylu/8195160.12. I tested on my local Linux machine without any RDMA devices. The issue with the two test cases is resolved. Please review and let me know if you see anything else is missing.

Thanks,
Lucy


From: nio-dev [mailto:nio-dev-bounces at openjdk.java.net] On Behalf Of Lu, Yingqi
Sent: Friday, September 28, 2018 4:26 PM
To: Brian Burkhalter <brian.burkhalter at oracle.com>
Cc: Aundhe, Shirish <shirish.aundhe at intel.com>; nio-dev at openjdk.java.net; Viswanathan, Sandhya <sandhya.viswanathan at intel.com>; Kaczmarek, Eric <eric.kaczmarek at intel.com>
Subject: RE: adding rsockets support into JDK

Hi Brian,

Thank you for testing it out. It seems like the tests have issues handling the environment that does not have RDMA devices.

I will look into this and get back to the mailing list by Monday.

Thanks,
Lucy

From: Brian Burkhalter [mailto:brian.burkhalter at oracle.com]
Sent: Friday, September 28, 2018 4:22 PM
To: Lu, Yingqi <yingqi.lu at intel.com<mailto:yingqi.lu at intel.com>>
Cc: Alan Bateman <Alan.Bateman at oracle.com<mailto:Alan.Bateman at oracle.com>>; nio-dev at openjdk.java.net<mailto:nio-dev at openjdk.java.net>; Viswanathan, Sandhya <sandhya.viswanathan at intel.com<mailto:sandhya.viswanathan at intel.com>>; Aundhe, Shirish <shirish.aundhe at intel.com<mailto:shirish.aundhe at intel.com>>; Kaczmarek, Eric <eric.kaczmarek at intel.com<mailto:eric.kaczmarek at intel.com>>
Subject: Re: adding rsockets support into JDK

Hi Lucy,

On Sep 25, 2018, at 12:58 PM, Lu, Yingqi <yingqi.lu at intel.com<mailto:yingqi.lu at intel.com>> wrote:

Please find webrev.11 is available athttp://cr.openjdk.java.net/~ylu/8195160.11/

[...]

With the above changes, all test cases pass on my Linux CentOS 7 box.

I get the failures [1, 2] when this version is run on my local build (Ubuntu 18.04 VM).

Thanks,

Brian

[1] jdk/net/Sockets/rsocket/ServerSocketChannel/SocketOptionTests.java

java.net.SocketException: No such device
        at jdk.net/jdk.internal.net.rdma.RdmaNet.socket0<http://jdk.net/jdk.internal.net.rdma.RdmaNet.socket0>(Native Method)
        at jdk.net/jdk.internal.net.rdma.RdmaNet.serverSocket<http://jdk.net/jdk.internal.net.rdma.RdmaNet.serverSocket>(RdmaNet.java:161)
        at jdk.net/jdk.internal.net.rdma.RdmaServerSocketChannelImpl<http://jdk.net/jdk.internal.net.rdma.RdmaServerSocketChannelImpl>.<init>(RdmaServerSocketChannelImpl.java:84)
        at jdk.net/jdk.internal.net.rdma.LinuxRdmaPollSelectorProvider.openServerSocketChannel<http://jdk.net/jdk.internal.net.rdma.LinuxRdmaPollSelectorProvider.openServerSocketChannel>(LinuxRdmaPollSelectorProvider.java:51)
        at jdk.net/jdk.internal.net.rdma.RdmaPollSelectorProvider.openServerSocketChannel<http://jdk.net/jdk.internal.net.rdma.RdmaPollSelectorProvider.openServerSocketChannel>(RdmaPollSelectorProvider.java:67)
        at jdk.net/jdk.net.Sockets.openRdmaServerSocketChannel<http://jdk.net/jdk.net.Sockets.openRdmaServerSocketChannel>(Sockets.java:493)
        at SocketOptionTests.main(SocketOptionTests.java:55)

[2] jdk/net/Sockets/rsocket/SocketChannel/SocketOptionTests.java

java.net.SocketException: No such device
        at jdk.net/jdk.internal.net.rdma.RdmaNet.socket0<http://jdk.net/jdk.internal.net.rdma.RdmaNet.socket0>(Native Method)
        at jdk.net/jdk.internal.net.rdma.RdmaNet.socket<http://jdk.net/jdk.internal.net.rdma.RdmaNet.socket>(RdmaNet.java:157)
        at jdk.net/jdk.internal.net.rdma.RdmaNet.socket<http://jdk.net/jdk.internal.net.rdma.RdmaNet.socket>(RdmaNet.java:150)
        at jdk.net/jdk.internal.net.rdma.RdmaSocketChannelImpl<http://jdk.net/jdk.internal.net.rdma.RdmaSocketChannelImpl>.<init>(RdmaSocketChannelImpl.java:96)
        at jdk.net/jdk.internal.net.rdma.LinuxRdmaPollSelectorProvider.openSocketChannel<http://jdk.net/jdk.internal.net.rdma.LinuxRdmaPollSelectorProvider.openSocketChannel>(LinuxRdmaPollSelectorProvider.java:46)
        at jdk.net/jdk.internal.net.rdma.RdmaPollSelectorProvider.openSocketChannel<http://jdk.net/jdk.internal.net.rdma.RdmaPollSelectorProvider.openSocketChannel>(RdmaPollSelectorProvider.java:63)
        at jdk.net/jdk.net.Sockets.openRdmaSocketChannel<http://jdk.net/jdk.net.Sockets.openRdmaSocketChannel>(Sockets.java:471)
        at SocketOptionTests.main(SocketOptionTests.java:54)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20180930/2238514c/attachment.html>