8221852: SYMBOLIC_LINK_FLAG_ALLOW_UNPRIVILEGED_CREATE should be selected at runtime, not build time

[Brian Burkhalter]

> On Apr 5, 2019, at 8:36 AM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> 
>> I have no objection to your #4, at least temporarily until you've found a good approach.
> 
> My inclination is to roll back the code to its state prior to [2]. This could be done under the current issue 8221852 or a new issue. Work on another approach can proceed then as time permits.

Well, after all I put together a different patch [A]. This reverts the native file to the version before the patch for 8218418. It moves all logic of the previous option 2 out of native code and out of the dispatcher code. The main change is the addition of WindowsLinkSupport.CreateSymLink(). The use of WindowsNativeDispatcher.CreateSymbolicLink() is replaced by this method in WindowsFileCopy and WindowsFileSystemProvider. There is also no change applied or needed with respect to obtaining more information about the OS version (build number).

Testing on Windows 7 shows the same behavior as before 8218418. If the approach seems reasonable I can verify it on the other previously tested platforms (CI testing is in progress).

Thanks,

Brian

[A] http://cr.openjdk.java.net/~bpb/8221852/webrev-option-2.01/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190405/2170f400/attachment.html>