8221852: SYMBOLIC_LINK_FLAG_ALLOW_UNPRIVILEGED_CREATE should be selected at runtime, not build time

[Alan Bateman]

On 05/04/2019 23:47, Brian Burkhalter wrote:
>
> Well, after all I put together a different patch [A]. This reverts the 
> native file to the version before the patch for 8218418. It moves all 
> logic of the previous option 2 out of native code and out of the 
> dispatcher code. The main change is the addition of 
> WindowsLinkSupport.CreateSymLink(). The use of 
> WindowsNativeDispatcher.CreateSymbolicLink() is replaced by this 
> method in WindowsFileCopy and WindowsFileSystemProvider. There is also 
> no change applied or needed with respect to obtaining more information 
> about the OS version (build number).
>
I think it will error prone/confusion to have CreateSymLink in one 
source file and CreateSymbolicLink in another, it might be simply e to 
just move the the NOT_HELD handling into 
WindowsNativeDispatcher.CreateSymbolicLink. More medium term, we need to 
bring back the OS version detection in WindowsFileSystem so that it can 
set flags as to what features are supported depending on the OS version 
at runtime.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190406/5572261c/attachment.html>