8222774: (ch) Replace uses of stateLock and blockingLock with explicit locks

[Brian Burkhalter]

Hi Alan, Daniel,

> On Apr 23, 2019, at 7:34 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> 
> I have read through the patch and didn't see anything
> too surprising. I might not have followed all the subtleties
> though - so another pair of eyes would be good.


I went through the patch yesterday and this morning and do not see any problems either.

Missing javadoc:

src/java.base/share/classes/sun/nio/ch/SelChImpl.java
Line 95: missing documentation before park(int)

> On Apr 23, 2019, at 8:12 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
>> AdaptorStreams.java:
>> 
>> Has this test run through tier8? This is where the special
>> VM configurations happen - and it's been known to trigger
>> intermittent failure more often than the other tiers.
>> 
>> I see the test use 1000 and 2000 millis, reasoning that if
>> the timeout is 2000ms then something scheduled to happen
>> after 1000ms should not trigger the timeout - and I wonder
>> how stable that is going to be.
> Daniel and I went through each of the tests using a timeout and I think we've satisfied ourselves that the timeouts are long enough so that there shouldn't be an issue on really slow test machines/

When the test is run on my machine without the source patch applied it timed out in testConcurrentReadWrite1() but passes with the patch.

The @bug tag lists 4430139 which I suppose is intentional.

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190423/4fdd78f7/attachment.html>