RFR (S): 8223015: Cleanups for zipfs tests

Langer, Christoph christoph.langer at sap.com
Fri Apr 26 12:35:51 UTC 2019


Hi,

please help reviewing these cleanups to the zipfs tests. In detail:

- Fix warnings in test/jdk/jdk/nio/zipfs/Demo.java (not a real testcase but Demo coding)
- change some calls of Runtime.version().major() to Runtime.version().feature() (the former is deprecated)
- change occurences of new Integer() to Integer.valueOf()
- change occurences of class.newInstance() to class.getDeclaredConstructor().newInstance()
- remove unused variables
- move test/jdk/jdk/nio/zipfs/jarfs/JFSTester.java to test/jdk/jdk/nio/zipfs/JFSTester.java (not using the jarfs subfolder). There is no need for this specific subfolder, given that MultiReleaseJarTest.java neither isn't in the jarfs subfolder

Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8223015.0/
Bug: https://bugs.openjdk.java.net/browse/JDK-8223015

I verified that the tests still succeed with the change.

Thanks
Christoph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190426/5153b295/attachment.html>


More information about the nio-dev mailing list