Found different in behavior of SocketInputStream#read in JDK13

[Enrico Olivelli]

Il giorno gio 1 ago 2019 alle ore 11:14 Szalay-Bekő Máté <
szalay.beko.mate at gmail.com> ha scritto:

> Thanks for the clarification!
>
> Indeed it should be the case. Our test behaves similarly than the minimal
> case sent by Chris (I also tested it with the JDK versions we use in
> Zookeeper).
>
> Regards,
> Mate
>
> On Thu, Aug 1, 2019 at 1:13 AM Alan Bateman <Alan.Bateman at oracle.com>
> wrote:
>
>> On 31/07/2019 15:58, Chris Hegarty wrote:
>> > :
>> >
>> >
>> > The change in behaviour comes from the `close` on the server-side
>> > shutting down the output before closing the socket. When debugging this
>> > issue the linger value being returned ( on my mac ) is -1, meaning that
>> > the option is disabled.
>> >
>> > I'll need to do some testing on the above patch, but on the face of it
>> > I believe that `shutdown` should only be called if the linger value is
>> > positive.
>> >
>> shutdown should only be called here if linger is disabled. I suspect the
>> change in behavior is that it is only done consistently on Windows in
>> the old SocketImpl, it is done on all platforms in the new impl.
>>
>

Just to be clear. What is the plan now ? to leave JDK13 as it is currently
or to change the behavior ?
If I understand correctly Alan's answer means that the new behavior in
JDK13 is now consistent across Windows, Linux and Mac and we want to keep
it
so it is better to adapt application code.

Enrico




>
>> -Alan
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190801/6440da06/attachment.html>