RFR: 8229872: (fs) Increase buffer size used with getmntent

Brian Burkhalter brian.burkhalter at oracle.com
Tue Aug 20 19:40:43 UTC 2019


Hello Vladimir,

L2: The newer copyright year should be changed to 2019.
L170: The line is too long.
L236: Before this line I think you should free() linebuffer.

Thanks,

Brian

> On Aug 20, 2019, at 12:31 PM, Vladimir Kempik <vkempik at azul.com> wrote:
> 
> after reading manpage for getline I think I have found some elegant solution - to let getline manage size of buffer.
> 
> Please review v2 of patch here http://cr.openjdk.java.net/~vkempik/8229872/webrev.02/ <http://cr.openjdk.java.net/~vkempik/8229872/webrev.02/>
> 
> I’m still worried about syncing maxlinelen and linebuffer between Java_sun_nio_fs_LinuxNativeDispatcher_setmntent0 and Java_sun_nio_fs_LinuxNativeDispatcher_getmntent, if they are run from different threads.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190820/60bd71c1/attachment.html>


More information about the nio-dev mailing list