RFR 8211360 : Change #if DEF to #if defined(DEF)

Ivan Gerasimov ivan.gerasimov at oracle.com
Wed Aug 21 20:58:17 UTC 2019


Thank you Brian and Vyom for reviewing it!

With kind regards,

Ivan


On 8/20/19 11:01 PM, Vyom Tewari26 wrote:
> Hi Ivan,
> Changes look good to me.
> Thanks,
> Vyom
>
>     ----- Original message -----
>     From: Ivan Gerasimov <ivan.gerasimov at oracle.com>
>     Sent by: "nio-dev" <nio-dev-bounces at openjdk.java.net>
>     To: core-libs-dev <core-libs-dev at openjdk.java.net>,
>     "nio-dev at openjdk.java.net" <nio-dev at openjdk.java.net>,
>     security-dev at openjdk.java.net
>     Cc:
>     Subject: [EXTERNAL] RFR 8211360 : Change #if DEF to #if defined(DEF)
>     Date: Tue, Aug 20, 2019 11:09 PM
>     Hello!
>
>     It's a followup for JDK-8211146.
>
>     With that fix several C-preprocessor statements of form #elif
>     __linux__
>     were changed to more accurate #elif defined(__linux__).
>
>     grep found a few more occurrences of the same pattern, which also
>     would
>     better be cleaned up.
>
>     BUGURL: https://bugs.openjdk.java.net/browse/JDK-8211360
>     WEBREV: http://cr.openjdk.java.net/~igerasim/8211360/00/webrev/
>
>     Mach5 control build/testing went fine on all platforms.
>     Would you please help review?
>
>     --
>     With kind regards,
>     Ivan Gerasimov
>
>
-- 
With kind regards,
Ivan Gerasimov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190821/f76de07e/attachment.html>


More information about the nio-dev mailing list