RFR 8235475: Add additional timestamp to test java/nio/channels/Selector/SelectWithConsumer.java

Alan Bateman Alan.Bateman at oracle.com
Fri Dec 6 11:27:00 UTC 2019


On 06/12/2019 11:13, Michael McMahon wrote:
> Hi,
>
> Could I get the following small instrumentation change to a test, 
> reviewed please?
>
> It just adds some additional logging for the case when the test fails.
The existing assert prints a message like this when it fails:

java.lang.AssertionError: select took 1813 ms expected [true] but found 
[false]

so probably better to expand the existing message so that the crumbs 
aren't split between the assert and a trace message sent to System.out.

I suspect we will need to change this test to use System.nanoTimes, 
maybe for another issue.

-Alan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20191206/68dd2a1c/attachment.html>


More information about the nio-dev mailing list