RFR 8235475: Add additional timestamp to test java/nio/channels/Selector/SelectWithConsumer.java

Alan Bateman Alan.Bateman at oracle.com
Fri Dec 6 12:12:57 UTC 2019


On 06/12/2019 11:56, Michael McMahon wrote:
>
> :
>
> I changed to use nanoTime in this test only, which should guarantee 
> the highest millisecond resolution
>
Okay although I think we will need a follow-on to change the other 
usages in this file so that we don't have a mix - can you create a 
follow-on issue?

The patch creates inconsistencies in the naming. I think "pre" need to 
renamed to "before". It looks like "duration" needs to renamed too, 
probably to "selectDuration" so that we don't have a mix of naming 
conventions in this one test.

-Alan.



More information about the nio-dev mailing list