8236184: (dc) IP_MULTICAST_* and IP_TOS socket options not effective

[Daniel Fuchs]

On 18/12/2019 18:59, Alan Bateman wrote:
> So in this Windows scenario it would indeed 
> set the IPv4 socket option twice. Harmless but L384 should be:
> 
> if (family != StandardProtocolFamily.INET && needToSetIPv4Option) {
> 

+1

> The @requires limits the platforms that it runs on so macOS is skipped 
> because IPv4 socket options are not effective on IPv6 sockets there. 
> There are several issues open in JBS on this, the workaround is 
> -Djava.net.preferIPv4Stack=true on macOS. MulticastSocket has the same 
> issue of course.

Ah! I missed the @requires.

Looks good.

-- daniel

> 
> -Alan