8236246: SelectorProvider support for creating a DatagramChannel that is not interruptible

Chris Hegarty chris.hegarty at oracle.com
Thu Dec 19 17:27:59 UTC 2019



> On 19 Dec 2019, at 16:58, Chris Hegarty <chris.hegarty at oracle.com> wrote:
> 
>> ...
>> http://cr.openjdk.java.net/~alanb/8236246/webrev/
> 
> 
> This seems fine.
> 
> There is a lot of duplication between the platform-specific
> DefaultSelectorProvider code. Can this be consolidated?

An additional minor thought, maybe SelectorProviderImpl can add the
@Override annotation to the overridden methods, from SelectorProvider,
( making it blatantly obvious that this new method is not part of SP ).

-Chris.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20191219/2773cdf7/attachment.htm>


More information about the nio-dev mailing list