adding rsockets support into JDK

Alan Bateman Alan.Bateman at oracle.com
Thu Feb 7 13:42:46 UTC 2019


On 06/02/2019 22:34, Brian Burkhalter wrote:
> Hi Lucy,
>
> Great! Now it should be good to go.
>
I went through the javadoc. Overall I think it looks good but there are 
a few places where it can be tweaked a bit to be consistent with the 
existing wording in StandardSocketOption, ServerSocketChannel and a few 
other places. There is also one or two places where the links are a bit 
strange, e.g. openServerSocketChannel was incorrectly linking to methods 
in SocketChannel. Finally, we can put a statement in the RdmaSockets 
class description to avoid the @throws NPE in all methods. I've pushed a 
change to the sandbox with these tweaks. I hope that is okay (I realize 
we risk too many cooks here but the sandbox is great for this sort of 
collaboration).

-Alan

[1] http://hg.openjdk.java.net/jdk/sandbox/rev/12c7d6b3ec28


More information about the nio-dev mailing list