5029431: (bf) Add absolute bulk put and get methods

Brian Burkhalter brian.burkhalter at oracle.com
Tue Feb 12 01:58:33 UTC 2019


> On Feb 11, 2019, at 10:32 AM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> […]
> 
> The foregoing changes are applied in:
> 
> http://cr.openjdk.java.net/~bpb/5029431/webrev.01/ <http://cr.openjdk.java.net/~bpb/5029431/webrev.01/>
> On Feb 10, 2019, at 8:17 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> put(index, src, offset, length) need discussion and okay to move to a separate issue if you want. The absolute version of put(src) is put(index, src), going further would be put(index, src, srcIndex, int length). The rename of "offset" to "srcIndex" is deliberate as it would be too easy to assume the offset is from the buffer's position. Another thing to mention is that put(src) throws IAE when you the source is the same buffer. If you are allow the source to be the same buffer in the absolute version then it will need to specify how overlapping regions are handled.

The above webrev is further updated in place to address the comments in the preceding paragraph regarding offset -> srcIndex and handling the same buffer. The method put(index,src) is not (yet) added.

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190211/629fa2c1/attachment.html>


More information about the nio-dev mailing list