5029431: (bf) Add absolute bulk put and get methods
Brian Burkhalter
brian.burkhalter at oracle.com
Wed Feb 13 01:36:23 UTC 2019
> On Feb 12, 2019, at 1:18 AM, Chris Hegarty <chris.hegarty at oracle.com <mailto:chris.hegarty at oracle.com>> wrote:
>
>> On 12 Feb 2019, at 08:49, Alan Bateman <Alan.Bateman at oracle.com <mailto:Alan.Bateman at oracle.com>> wrote:
>>
>> On 11/02/2019 22:30, Brian Burkhalter wrote:
>>>
>>> […]
>>>
>>> Note that using Buffer*flowException would require an update to the specifications of these exceptions as now they are described as being specific to relative operations.
>>>
>> I think you are on the right track with this thinking. That is, throw IOOBE when index is negative or >= limit, throw the Buffer*flowExceptions if the transfer would result in buffer overflow/underflow. I think that will fix the inconsistency with the current proposal and also helps with the troubleshooting a bit. Yes, it does mean a small adjustment to the wording in the exceptions.
>
> Agreed.
I have revised the specifications of exceptions for the five methods in question and updated the tests accordingly:
http://cr.openjdk.java.net/~bpb/5029431/webrev.02/ <http://cr.openjdk.java.net/~bpb/5029431/webrev.02/>
I have not yet updated the wording of the Buffer*flowException classes to remove the restriction to relative operations. I can do that once the rest looks good.
Thanks,
Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190212/bd3f513a/attachment.html>
More information about the nio-dev
mailing list