5071718: (bf) Add ByteBuffer.slice(int offset, int length)

[Brian Burkhalter]

Hi Brent,

That does read better. I’ll hold off on updating the webrev however until more comments come in.

Thanks,

Brian

> On Feb 25, 2019, at 4:30 PM, Brent Christian <brent.christian at oracle.com> wrote:
> 
> A nit for the new javadoc:
> 
> I find it a little weird for one paragraph to start, "The new buffer will start at position {@code index}...", and the next paragraph to start, "The new buffer's position will be zero."
> 
> I find the no-arg slice()'s reference to "the content of the new buffer" to be a bit clearer.  So my suggestion would be, e.g.:
> 
> "The content of the new buffer will start at position {@code index} in this buffer, and will contain {@code length} elements."

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190225/da862364/attachment.html>