8219597: (bf) Heap buffer state changes could provoke unexpected exceptions

Roger Riggs roger.riggs at oracle.com
Wed Feb 27 20:10:03 UTC 2019


Hi Brian,

The changes look fine.

Alan's comments not withstanding, I'd be inclined to close it as WNF 
because it does not improve the concurrency situation and may further 
hide cases where the caller should be doing synchronization. With this 
change will be harder to observe that something is going wrong.

Roger


On 2/27/19 2:36 PM, Brian Burkhalter wrote:
> This issue [1] was instigated by this comment [2]. The change [3] hopefully reduces the exposure of heap buffers to changes in the buffer state, notably the position (cursor).
>
> Thanks,
>
> Brian
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8219597
> [2] http://mail.openjdk.java.net/pipermail/nio-dev/2019-February/005900.html
> [3] http://cr.openjdk.java.net/~bpb/8219597/webrev.00/



More information about the nio-dev mailing list