adding rsockets support into JDK

Brian Burkhalter brian.burkhalter at oracle.com
Tue Jan 29 19:22:28 UTC 2019


> On Jan 29, 2019, at 6:55 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
>> The part of the spec that talks about the SelectorProvider is still
>> relevant, even though the provider is not directly accessible from the
>> RdmaSockets class.
>> 
>> The SelectorProvider is indirectly accessible from a Selector or
>> AbstractSelectableChannel, e.g.:
>>   SelectorProvider sp = RdmaSockets.openSelector().provider();
>>   SelectorProvider sp = RdmaSockets.openSocketChannel(INET).provider();

Ah, of course.

> Right, this is reason for the wording in the class description. I think I provided these sentences for the javadoc a few months ago.

By the same token, perhaps the first sentence of the RDMASockets class description should be changed from

"Factory methods for creating RDMA-based TCP sockets and channels.”

to

"Factory methods for creating RDMA-based TCP sockets and socket channels.”

Also, and this is being picky, the “Its” in "Its selector provider does not support datagram channels and pipes.” reads a little awkward to me. Maybe instead something like this?:

“The RDMA selector provider also does not support datagram channels and pipes. Its openDatagramChannel <file:///Users/bpb/Work/CoreLibs/jdk/sandbox/build/macosx-x86_64-server-release/images/docs/api/java.base/java/nio/channels/spi/SelectorProvider.html#openDatagramChannel()> andopenPipe <file:///Users/bpb/Work/CoreLibs/jdk/sandbox/build/macosx-x86_64-server-release/images/docs/api/java.base/java/nio/channels/spi/SelectorProvider.html#openPipe()> methods throw UnsupportedOperationException <file:///Users/bpb/Work/CoreLibs/jdk/sandbox/build/macosx-x86_64-server-release/images/docs/api/java.base/java/lang/UnsupportedOperationException.html>.”

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190129/713ad9f8/attachment-0001.html>


More information about the nio-dev mailing list