Redux 8184157: (ch) AsynchronousFileChannel hangs with internal error when reading locked file
Brian Burkhalter
brian.burkhalter at oracle.com
Mon Jul 22 20:49:10 UTC 2019
> On Jul 21, 2019, at 6:15 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>
> I went through webrev.03, where the change to WindowsAsynchronousSocketChannelImpl is partial reverted, and I think it's looking good except for LockTask.pending as that shouldn't be needed now.
LockTask.pending removed in [1].
> I see the test has been cleaned up (thanks), but wondering if L51 to close the channel can be removed as it should be closed by way of the try-with-resources. Also would be nice to avoid the line break at L45. The Files.delete at L55 is probably not needed either.
Foregoing suggested changes made and also changed L41 of the test from
Path path = Path.of(System.getProperty("test.dir", "."), "blah");
to
Path path = Path.of("blah");
Thanks,
Brian
[1] http://cr.openjdk.java.net/~bpb/8184157/webrev.04/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190722/91d12a64/attachment.html>
More information about the nio-dev
mailing list