8227609: (fs) Files.newInputStream(...).skip(n) should allow skipping beyond file size

Brian Burkhalter brian.burkhalter at oracle.com
Thu Jul 25 20:46:28 UTC 2019


> On Jul 25, 2019, at 12:58 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> On 25/07/2019 19:14, Brian Burkhalter wrote:
>> 
>> Updated as suggested; test modified accordingly.
>> 
>> http://cr.openjdk.java.net/~bpb/8227609/webrev.01/ <http://cr.openjdk.java.net/~bpb/8227609/webrev.01/>
>> 
>> 
> This looks okay.
> 
> Can the test be expanded to include cases where the result differs to the input, e.g. skip(-<pos>*2) should return -<pos>, skip(Long.MIN_VALUE) return should -<pos>, etc.

Some new cases added: http://cr.openjdk.java.net/~bpb/8227609/webrev.02/.

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190725/d9f309ca/attachment-0001.html>


More information about the nio-dev mailing list