8227609: (fs) Files.newInputStream(...).skip(n) should allow skipping beyond file size8

Brian Burkhalter brian.burkhalter at oracle.com
Tue Jul 30 15:22:00 UTC 2019


> On Jul 30, 2019, at 6:57 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> On 29/07/2019 12:51, Brian Burkhalter wrote:
>> 
>> I updated it to clamp to the size and changed the test accordingly:
>> 
>> http://cr.openjdk.java.net/~bpb/8227609/webrev.03/ <http://cr.openjdk.java.net/~bpb/8227609/webrev.03/>
>> 
> This looks good. You've commented out the tests from the previous revision - are you planning to remove those before pushing?

Yes, they duplicate others in there but I was undecided as to whether to replace them with something else. I’ll delete them before checking it in.

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190730/5a25010a/attachment.html>


More information about the nio-dev mailing list