RFR 8216417: cleanup of IPv6 scope-id handling

Michael McMahon michael.x.mcmahon at oracle.com
Tue Jun 11 09:04:02 UTC 2019


Good point Daniel. Thanks for the review.

- Michael.

On 10/06/2019, 19:48, Daniel Fuchs wrote:
> Hi Michael,
>
> AbstractPlainDatagramSocketImpl.java:
>
> in `send` maybe the packet should only be recreated if the address
> is different.
>
> best regards,
>
> -- daniel
>
> On 10/06/2019 15:18, Michael McMahon wrote:
>> Hi,
>>
>> Could I get the following change to net/nio reviewed please?
>>
>> It is a general cleanup of IPv6 scope_id handling which removes
>> a lot of native code trickery (mostly in Linux) and simplifies the 
>> handling
>> of scope_ids such that:
>>
>> a) when binding/connecting/sending to a link-local address on the 
>> same machine,
>>     it is allowed to use addresses without a scope_id. In this case, 
>> we check local NetworkInterfaces
>>     for the correct scope_id to use.
>>
>> b) when connecting/sending to a remote link-local address, then a 
>> scope_id must be specified
>>      at all times.
>>
>> Scope_ids should be handled consistently between net and NIO and 
>> across all platforms now.
>>
>> http://cr.openjdk.java.net/~michaelm/8216417/webrev.2/index.html
>>
>> Thanks,
>> Michael
>


More information about the nio-dev mailing list