8223813: (aio) Iocp.getErrorMessage should drop trailing \r\n

[Roger Riggs]

Hi Brian,

I'm fine with the current webrev too.  it does the job and is specific.

I agree about it not likely to be worth the effort.

Thanks, Roger



On 06/11/2019 03:56 PM, Brian Burkhalter wrote:
> Hi Roger,
>
> Thanks for the $0.02.
>
>> On Jun 11, 2019, at 12:14 PM, Roger Riggs <Roger.Riggs at Oracle.com 
>> <mailto:Roger.Riggs at Oracle.com>> wrote:
>>
>> Having the extraneous suffix consistently removed seems like a good 
>> thing.
>> Though I'm not sure what the best form of the utility function is:
>>  1) return the count of characters to remove
>>  2) just truncate the buffer.
>
> I am not sure either nor am I convinced that it would even be worth 
> the effort. As mentioned there are already getLastErrorString() and 
> getErrorString() for chars so I suppose the equivalent for WCHARs 
> would need to be added for at least one of these.
>
>> There may be ways to force some of the errors that would lead to the 
>> truncation, but testing all uses will not be practical.
>
> That’s what I thought.
>
> Thanks,
>
> Brian