8226706: (se) Reduce the number of outer loop iterations on Windows in java/nio/channels/Selector/RacyDeregister.java

[Lance Andersen]

Go for it :-)
> On Jun 25, 2019, at 1:57 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> 
> 
>> On Jun 24, 2019, at 4:03 PM, Brian Burkhalter <brian.burkhalter at oracle.com <mailto:brian.burkhalter at oracle.com>> wrote:
>> 
>> https://bugs.openjdk.java.net/browse/JDK-8226706 <https://bugs.openjdk.java.net/browse/JDK-8226706>
>> 
>> The number of outer loop iterations of this test was increased, for Windows only, by the patch that resolved [1]. A comment was also added to the test reminding to reset the number of iterations back down to its previous smaller value once [2] was resolved. Subsequently [2] was resolved as irreproducible but the number of iterations in the test was not in fact reduced. As the higher number of iterations might be the reason for the failure in [3], it is proposed here to change the number of outer loop resolutions from 150 on Windows back to 15, the same as on the other platforms.
> 
> These references were inadvertently left out of my RFR:
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8163305 <https://bugs.openjdk.java.net/browse/JDK-8163305>
> [2] https://bugs.openjdk.java.net/browse/JDK-8161083 <https://bugs.openjdk.java.net/browse/JDK-8161083>
> [3] https://bugs.openjdk.java.net/browse/JDK-8201765 <https://bugs.openjdk.java.net/browse/JDK-8201765>
> 
>> 
>> Thanks,
>> 
>> Brian
>> 
>> --- a/test/jdk/java/nio/channels/Selector/RacyDeregister.java
>> +++ b/test/jdk/java/nio/channels/Selector/RacyDeregister.java
>> @@ -41,11 +41,6 @@
>>   */
>>  public class RacyDeregister {
>>  
>> -    // FIXME: NUM_OUTER_LOOP_ITERATIONS should be reverted to the hard-coded
>> -    // value 15 when JDK-8161083 is resolved as either a bug or a non-issue.
>> -    static final int NUM_OUTER_LOOP_ITERATIONS =
>> -        System.getProperty("os.name").startsWith("Windows") ? 150 : 15;
>> -
>>      // 90% of 1200 second timeout as milliseconds
>>      static final int TIMEOUT_THRESHOLD_MILLIS = 1200*900;
>>  
>> @@ -90,7 +85,7 @@
>>  
>>              public void run() {
>>                  try {
>> -                    for (int k = 0; k < NUM_OUTER_LOOP_ITERATIONS; k++) {
>> +                    for (int k = 0; k < 15; k++) {
>>                          System.out.format("outer loop %3d at %7d ms%n", k,
>>                              System.currentTimeMillis() - t0);
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190625/a7e5bf17/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: oracle_sig_logo.gif
Type: image/gif
Size: 658 bytes
Desc: not available
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190625/a7e5bf17/oracle_sig_logo-0001.gif>