8219876: (bf) Improve IndexOutOfBoundsException messages in $Type$Buffer classes

[Alan Bateman]

On 28/02/2019 21:57, Brian Burkhalter wrote:
>
>> On Feb 27, 2019, at 11:57 PM, Alan Bateman <Alan.Bateman at oracle.com 
>> <mailto:Alan.Bateman at oracle.com>> wrote:
>>
>> I assume you'll run benchmarks and/or look at the generated code to 
>> make sure that the checks inline as expected.
>
> The benchmark output [1] shows a small improvement for a 1024-byte 
> bulk get and a slight degradation for a 1-byte bulk get. The benchmark 
> code is [2].
>
> The disassembled classes [3] (from ‘javap -c’) differ in the presence 
> of a “pop” for the new code containing Objects.checkFromIndexSize().
>
I should have been clearer, I meant the code generated at runtime, as in 
-XX:+PrintAssembly but if you are doing benchmarks to make sure the 
changes don't regress then it should be good.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190301/853c859e/attachment-0001.html>