RFR 8218875: Add new FileSystems.newFileSystem methods
Roger Riggs
Roger.Riggs at oracle.com
Thu May 2 13:35:20 UTC 2019
Hi Lance,
Can the edits in jdk.compiler replacing null with (ClassLoader)null use
the 1 arg form of newFileSystem?
Or are they needed for the version-1 bootstrap compilation?
Wildcard imports are discouraged (in the new test).
Test method names that are indicative of the function being tested can
be helpful when
reading a test log, it communicates a bit sooner what has gone wrong
without having to read
the test javadoc.
Thanks, Roger
On 05/02/2019 08:52 AM, Lance Andersen wrote:
> Thank you Alan for catching the missing “method”
>
> http://cr.openjdk.java.net/~lancea/8218875/webrev.03/index.html
> <http://cr.openjdk.java.net/%7Elancea/8218875/webrev.03/index.html> contains
> your suggested updates mentioned below
>
> Best
> Lance
>> On May 2, 2019, at 3:40 AM, Alan Bateman <Alan.Bateman at oracle.com
>> <mailto:Alan.Bateman at oracle.com>> wrote:
>>
>> On 01/05/2019 20:29, Lance Andersen wrote:
>>> Coming back to this.
>>>
>>> The updated webrev can be found at:
>>>
>>> http://cr.openjdk.java.net/~lancea/8218875/webrev.02/index.html
>>> <http://cr.openjdk.java.net/%7Elancea/8218875/webrev.02/index.html>
>>>
>> I only have time to look at the changes to FileSystems.java right now.
>>
>> One nit in the wording is in "in exactly the same manner as the
>> newFileSystem ..." - the word "method" has been dropped from the
>> original text. Looks like the same thing shows up in several places
>> so it would be good to fix those.
>>
>> Minor formatting nit on L472 where the "throws IOException" doesn't
>> need to be on its own line.
>>
>> -Alan
>>
>>
>>
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>
More information about the nio-dev
mailing list