RFR 8218875: Add new FileSystems.newFileSystem methods

[Langer, Christoph]

Hi Lance,

looks good to me, too.

A little nit in the test: line 173 should be:
Map<String, ?> nullMap = null;

Also you could remove the blank lines 87, 102, and 116 for consistency and declare the variable ZIPFS_SCHEME as private in line 52. But that’s bikeshedding ��

Best regards
Christoph


From: nio-dev <nio-dev-bounces at openjdk.java.net> On Behalf Of Lance Andersen
Sent: Donnerstag, 2. Mai 2019 17:57
To: Alan Bateman <Alan.Bateman at oracle.com>
Cc: nio-dev at openjdk.java.net
Subject: Re: RFR 8218875: Add new FileSystems.newFileSystem methods


On May 2, 2019, at 11:41 AM, Alan Bateman <Alan.Bateman at oracle.com<mailto:Alan.Bateman at oracle.com>> wrote:

On 02/05/2019 13:52, Lance Andersen wrote:

Thank you Alan for catching the missing “method”

http://cr.openjdk.java.net/~lancea/8218875/webrev.03/index.html contains your suggested updates mentioned below
Thanks, the javadoc looks good now. There's still one stray "{" at L473 that belongs on the previous line, otherwise looks fine.
Sorry about that missing that

Addressed here: http://cr.openjdk.java.net/~lancea/8218875/webrev.05/index.html

Best
Lance
-Alan

[cid:image001.gif at 01D50136.6771A320]<http://oracle.com/us/design/oracle-email-sig-198324.gif>

<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com<mailto:Lance.Andersen at oracle.com>




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190502/9a8325d3/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.gif
Type: image/gif
Size: 658 bytes
Desc: image001.gif
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190502/9a8325d3/image001.gif>