RFR : 8221696: MappedByteBuffer.force method to specify range

[Andrew Dinn]

On 26/04/2019 15:46, Alan Bateman wrote:
> On 25/04/2019 17:34, Andrew Dinn wrote:
>> Also, here is a new webrev including the updated implementations for
>> mappingAddress/Offset/Length as described below
>>
>> JIRA:   https://bugs.openjdk.java.net/browse/JDK-8221696
>> webrev: http://cr.openjdk.java.net/~adinn/8221696/webrev.02
>>
> This looks right and I agree with your notes on negative addresses. As 
> its tricky to get right then it would be good to get another set of eyes 
> on this.
> 
> A minor nit is that we don't usually use underscores in variable names 
> here, it would be baseAddress rather than base_address, etc.
Alan tested this for me on Windows and MacOS with a successfl outcome 
and oked the push in a private note. I pushed the patch yesterday -- 
modulo fixing the var names to use camelCase instead of under_score.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander