RFR : 8221696: MappedByteBuffer.force method to specify range

Andrew Dinn adinn at redhat.com
Tue May 14 08:00:42 UTC 2019


Hi Mikael,

Thanks for looking at this.

On 13/05/2019 17:41, Mikael Vidstedt wrote:
> 
> Would it be worth putting the logic in an aptly named (private) method? Something like:
> 
> ...
> private long alignDown(long address, long alignment) {
>     return address & <whatever>;
> }
> ...
> long mapBase = alignDown(address, ps);
>Yes, that would probably be an improvement. However, I am afraid the 
ship has already sailed. I pushed the patch last night on the strength 
of an ok from Alan posted after he tested the patch on Windows and 
MacOS. Perhaps I should fix this in the push of the associated JEP 
implementation?

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander


More information about the nio-dev mailing list