RFR: 8222807: Address iteration with invalid ZIP header entries

Claes Redestad claes.redestad at oracle.com
Sat May 18 01:14:19 UTC 2019


Hi Lance,

since needing to normalize should be very rare in practice it might be
profitable to outline that case, see similar code in
UnixFileSystem::normalize

You introduced int len = path.length but then use path.length
in most places.

/Claes

On 2019-05-18 01:46, Lance Andersen wrote:
> Hi all.
> 
> Please review the webrev for 8222807.  This deals with ZIP header 
> entries such as “foo//“. resulting in issues walking walking through a 
> ZIP archive.
> 
> The webrev can be found at: 
> http://cr.openjdk.java.net/~lancea/8222807/webrev.00/index.html.
> 
> I have verified that the mach5 tier1, tier2, and tier3 tests all pass.
> 
> Thank you and have a good weekend.
> 
> Best
> Lance
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| 
> Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
> 
> 
> 


More information about the nio-dev mailing list