8146298: (dc spec) connect and disconnect methods should specify that they may block

[Chris Hegarty]

> On 31 Oct 2019, at 20:07, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
>> ....
> 
> CSR filed: https://bugs.openjdk.java.net/browse/JDK-8233342 <https://bugs.openjdk.java.net/browse/JDK-8233342>.
> 

I think this is probably fine.

"Any datagrams received prior to connecting the socket are discarded.”

I assume that datagrams received by user code, prior to connecting, are in no way discarded, right?

I find the use of the naked term, “socket', in the implNote a little uncomfortable. Maybe “the channel’s socket” ?

That said, there are inconsistencies all over the place between “channel”, “socket”, and “channel’s socket” (I don’t suggest that you try to tackle them in this issue). Either that, or I don’t understand the subtle differences or the difference is not significant. For example, the connect method uses all three of these terms:

    /**
     * Connects this channel's socket.
     *
     * <p> The channel's socket is configured so that it only receives ...
     * ... A datagram socket remains connected until it is
     * explicitly disconnected or until it is closed.
     *
     * ...  If another thread has already initiated a read or
     * write operation upon this channel, ...
     * ... If this channel's socket is not bound then ...
     *
     * @implNote
     * Any datagrams received prior to connecting the socket are discarded.
     *
     * @param  remote
     *         The remote address to which this channel is to be connected
     *
     * @return  This datagram channel
     *
     * @throws  AlreadyConnectedException
     *          If this channel is already connected
     *
     * @throws  ClosedChannelException
     *          If this channel is closed
     * ...

-Chris.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20191101/6451324d/attachment.html>