8232673: (dc) DatagramChannel socket adaptor issues

Alan Bateman Alan.Bateman at oracle.com
Fri Nov 1 13:00:18 UTC 2019


On 01/11/2019 12:32, Daniel Fuchs wrote:
> Hi Alan,
>
> The new webrev looks good to me.
>
> Maybe the changes to DummySocketImpl.java, SocketChannelImpl.java, and
> ServerSocketChannelImpl.java could have been separated out since
> they have nothing to do with "DatagramChannel socket adaptor issues",
> but they look good to me anyway.
The change SocketChannelImpl and ServerSocketChannelImpl in webrev.02 
was to fix the issue that Chris pointed out in the first round. That is, 
the restoration of the blocking mode for a timed adaptor operation, 
would throw an exception if the channel had been closed. It didn't seem 
worth it at the time to split it out for the other channel types but I 
can do and push it at the same time.

-Alan


More information about the nio-dev mailing list