8146298: (dc spec) connect and disconnect methods should specify that they may block

[Alan Bateman]

On 12/11/2019 20:35, Brian Burkhalter wrote:
> :
>
> Webrev [1] and CSR [2] updated. The verbiage about discarding 
> datagrams is moved from an @implNote to normative text. There are two 
> attachments to the CSR with the same name as the server prevented 
> deleting the older one at this time. The CSR is moved back to draft 
> pending comments and will be re-finalized.
>
In the connect method, the paragraph "This method may be invoked ..." 
paragraph is about coordinating the setup of the connection with other 
threads that are doing send/receive at the same time. The wording is 
okay but the final sentence on the (potential) discarding of datagrams 
queued in the socket receive buffer is a separate concern and shouldn't 
be part of this paragraph. I think we should move it to its own 
paragraph or else move into the first paragraph where connected-ness is 
described.

I think "which have not been received" should link to #receive so that 
it is clearer that it means the receive method rather than received by 
the network/operating system. Also I think "socket receive buffer" 
should link to SO_RCVBUF rather than the @see so that there is something 
to click on the wonder comes across this a term that he/she hasn't seen 
before.

-Alan.