RFR 8234080: jdk/nio/zipfs/CRCWriteTest.java fails

[Langer, Christoph]

Hi Lance,

Looks correct ��

Best regards
Christoph

From: nio-dev <nio-dev-bounces at openjdk.java.net> On Behalf Of Lance Andersen
Sent: Mittwoch, 13. November 2019 18:27
To: nio-dev <nio-dev at openjdk.java.net>
Subject: RFR 8234080: jdk/nio/zipfs/CRCWriteTest.java fails

HI

Please review this test fix which I must have accidentally rolled back in intellij and did not catch.  I have run mach5 tests and it is passing (and running ;-) )

———————————
$ hg diff
diff -r 57ad70bcf06c test/jdk/jdk/nio/zipfs/CRCWriteTest.java
--- a/test/jdk/jdk/nio/zipfs/CRCWriteTest.java  Wed Nov 13 11:27:50 2019 +0000
+++ b/test/jdk/jdk/nio/zipfs/CRCWriteTest.java  Wed Nov 13 12:24:01 2019 -0500
@@ -57,10 +57,10 @@
      * can be used successfully with the OutputStream write methods
      */
     @Test
-    private void zipFsOsDeflatedWriteTest() throws Exception {
+    public void zipFsOsDeflatedWriteTest() throws Exception {
         Files.deleteIfExists(JAR_FILE);
         String[] msg = {"Hello ", "Tennis Anyone", "!!!!"};
-        Entry e0 = Entry.of("Entry-0", ZipEntry.DEFLATED, Arrays.toString(msg));
+        Entry e0 = Entry.of("Entry-0", ZipEntry.DEFLATED, String.join("",msg));

         try (FileSystem zipfs = FileSystems.newFileSystem(JAR_FILE,
                 Map.of("create", "true"))) {


———————————————

Best
Lance
[cid:image001.gif at 01D59A61.225FB320]<http://oracle.com/us/design/oracle-email-sig-198324.gif>

<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com<mailto:Lance.Andersen at oracle.com>




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20191113/786cdbd5/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.gif
Type: image/gif
Size: 658 bytes
Desc: image001.gif
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20191113/786cdbd5/image001-0001.gif>