8164993: (ch) ReadableByteChannel should note a possible ReadOnlyBufferException

[Brian Burkhalter]

> On Nov 19, 2019, at 9:39 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> On 19/11/2019 17:31, Brian Burkhalter wrote:
>> :
>> 
>> If there are multiple locations where this is needed then they should all be addressed. I’ll take another look.
> Thanks. ScatteringByteChannel.read, DatagramChannel.receive, and the FileChannel.read method that takes a position, are the methods that come to mind.

I’ve updated the change to include the other locations mentioned. I did not see any others.

Thanks,

Brian

--- a/src/java.base/share/classes/java/nio/channels/DatagramChannel.java
+++ b/src/java.base/share/classes/java/nio/channels/DatagramChannel.java

receive()

@@ -406,6 +406,9 @@
      * @throws  ClosedChannelException
      *          If this channel is closed
      *
+     * @throws  IllegalArgumentException
+     *          If the buffer is read-only
+     *
      * @throws  AsynchronousCloseException
      *          If another thread closes this channel
      *          while the read operation is in progress

--- a/src/java.base/share/classes/java/nio/channels/FileChannel.java
+++ b/src/java.base/share/classes/java/nio/channels/FileChannel.java

pread()

@@ -727,6 +727,9 @@
      * @throws  ClosedChannelException
      *          If this channel is closed
      *
+     * @throws  IllegalArgumentException
+     *          If the buffer is read-only
+     *
      * @throws  AsynchronousCloseException
      *          If another thread closes this channel
      *          while the read operation is in progress

--- a/src/java.base/share/classes/java/nio/channels/ReadableByteChannel.java
+++ b/src/java.base/share/classes/java/nio/channels/ReadableByteChannel.java

read()

@@ -90,6 +90,9 @@
      * @throws  ClosedChannelException
      *          If this channel is closed
      *
+     * @throws  IllegalArgumentException
+     *          If the buffer is read-only
+     *
      * @throws  AsynchronousCloseException
      *          If another thread closes this channel
      *          while the read operation is in progress

--- a/src/java.base/share/classes/java/nio/channels/ScatteringByteChannel.java
+++ b/src/java.base/share/classes/java/nio/channels/ScatteringByteChannel.java

scattering read 1

@@ -107,6 +107,9 @@
      * @throws  ClosedChannelException
      *          If this channel is closed
      *
+     * @throws  IllegalArgumentException
+     *          If any of the buffers is read-only
+     *
      * @throws  AsynchronousCloseException
      *          If another thread closes this channel
      *          while the read operation is in progress

scattering read 2

@@ -144,6 +147,9 @@
      * @throws  ClosedChannelException
      *          If this channel is closed
      *
+     * @throws  IllegalArgumentException
+     *          If any of the buffers is read-only
+     *
      * @throws  AsynchronousCloseException
      *          If another thread closes this channel
      *          while the read operation is in progress
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20191119/7f3cd7a9/attachment-0001.html>