RFR 8223771: (zipfs) FileSystemProvider.newFileSystem(Path, Map) should throw IOException when called with a file that cannot be open
Lance Andersen
lance.andersen at oracle.com
Thu Oct 3 18:52:01 UTC 2019
Thank you Alan.
> On Oct 3, 2019, at 2:43 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>
> On 03/10/2019 19:01, Lance Andersen wrote:
>> I updated the patch: http://cr.openjdk.java.net/~lancea/8223771/webrev.01/ as well as the CSR to reflect the change and lack of a property.
> Looks good. I tweaked a few things in the CSR and added myself as a Reviewer.
I finalized the CSR, thank you for adding yourself as a reviewer.
>
>>
>> I reverted the change which just returned the filename when the Exception is thrown. My reasoning for just returning the filename was based on https://www.oracle.com/technetwork/java/seccodeguide-139067.html#2 .
>>
> Right, there's a discussion topic there as exception messages can leak interesting file paths.
A discussion for a different day :-)
Best
Lance
>
> -Alan
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20191003/ce47e72f/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: oracle_sig_logo.gif
Type: image/gif
Size: 658 bytes
Desc: not available
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20191003/ce47e72f/oracle_sig_logo-0001.gif>
More information about the nio-dev
mailing list