8212132: (dc) Remove DatagramChannelImpl finalize method

Florian Weimer fweimer at redhat.com
Wed Oct 23 10:16:52 UTC 2019


* Alan Bateman:

> On 22/10/2019 16:38, Florian Weimer wrote:
>> :
>> What's the position on guarding against faillure in the cleaner
>> registration itself, sinde registerCleaner()?

> I assume you mean OOME.

Yes, OOME or maybe StackOverflow Error (although that is much more
tenuous).

> We don't handle that in the dozen or so other places that are using
> this mechanism so if it happens, and the application somehow recovers,
> then it would be a resource leak.

I see.  I wonder if these additional resource leaks have caused problems
in practice, since it is so common to catch OOME and keep running.  In
any case, this change matches the other migration to Cleaner, so it
shouldn't make matters much worse.

Thanks,
Florian



More information about the nio-dev mailing list