Resend RFR 8231766: Files.copy/move do not honor requested compression method when copying/moving within the same zip file

[Brian Burkhalter]

Hi Lance,

Please see comments on the test below listed by line numbers.

Brian

> On Oct 23, 2019, at 1:49 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> On 23/10/2019 18:48, Lance Andersen wrote:
>> Thanks for the suggestion Alan.
>> 
>> Webrev updated: http://cr.openjdk.java.net/~lancea/8231766/webrev.01/index.html <http://cr.openjdk.java.net/~lancea/8231766/webrev.01/index.html>
>> 
>> 
> Thanks, looks much simpler. The test is big and I don't have time to go through that in detail right now. Maybe Christoph or someone else might have cycles to help.

114
How can verify() return true if compression != expectedCompression? It looks like at 111 the contents of e0 are copied with e00’s name but retain e0’s compression method. Probably I am missing something.

148
Similar question as for line 114.

251
Similar question as for line 114

286
Similar question as for line 114

336
Could TestNG “expectedExceptions” parameter of the @Test annotation be used instead of catching the FAE (and put line 352 in a finally block)?

363-371
Could Files.createTempFile() be used instead of having this method?

447
Line commented out

110, 144, 181, 247, 280, 347, 399
Indentation
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20191023/60c865c6/attachment-0001.html>