8232673: (dc) DatagramChannel socket adaptor issues

[Chris Hegarty]

> On 29 Oct 2019, at 15:18, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> 
> Hi Alan,
> 
> Thanks for this patch that fixes and brings into the mainline
> many of the small issues we noticed while working on JDK-8230211.
> 
> I looked at the patch and I think it is good.

+1 Mainly looks very good. A few comments:

The window is small but, lockedConfigureBlocking should not call ensureOpen ( that may throw ), when invoked from the finally block, since there could be received data ( that might otherwise be thrown away ). The call to ensureOpen should be conditional.

Any reason why auxiliary classes are used, rather than static nested classes?

I share similar concerns about the use of assertions in combination with finally blocks, that Daniel has.

-Chris.